Fix deeplearning autoencoder implementation issues#151
Merged
tausiaj merged 3 commits intoJul 3, 2026
Conversation
Collaborator
Author
|
Hi @tausiaj, The CI checks have passed. This PR is ready for review. It includes the autoencoder smoke tests and the implementation fixes discussed in the PR description. I also verified the full test suite locally on Windows/Anaconda with: 213 passed. Happy to make any changes if you prefer a different design for the ConvLSTM/Hybrid reconstruction target or the StandardAutoencoder flattening behaviour. After this PR, I would be happy to contribute follow-up improvements in separate PRs, for example reconstruction-error utilities, PCA/autoencoder comparison examples, or anomaly-detection examples for climate/ocean data. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the implementation issues documented by the autoencoder smoke tests.
Changes include:
Local test result on Windows / Anaconda:
213 passed.