CI: Allow Tests and Docs workflows to pass for segment fault on Windows#4664
Merged
seisman merged 3 commits intoJun 5, 2026
Merged
Conversation
7993522 to
a206ed9
Compare
a206ed9 to
aa59acf
Compare
seisman
commented
Jun 4, 2026
| log_file="${RUNNER_TEMP}/sphinx-html.log" | ||
| make -C doc clean html 2>&1 | tee "${log_file}" | ||
| exit_code=${PIPESTATUS[0]} | ||
| if [[ "${RUNNER_OS}" == "Windows" && "${exit_code}" -eq 2 ]] && grep -q "make: .* Error 2816" "${log_file}"; then |
Member
Author
There was a problem hiding this comment.
make returns error code 2 with error message "Error 2816".
seisman
commented
Jun 4, 2026
seisman
commented
Jun 4, 2026
weiji14
approved these changes
Jun 4, 2026
This was referenced Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Tests and Docs workflows are failing on Windows due to unknown crashes. Previously, we disable the Docs workflow on Windows CI in #4151, but we can't disable the Tests workflow on Windows CI.
This PR takes a different workaround and ignores the crash on Windows.
The changes will be reverted in #4156 so that we know if the workaround is still necessary for future GMT versions.