Skip to content

CI: Allow Tests and Docs workflows to pass for segment fault on Windows#4664

Merged
seisman merged 3 commits into
GenericMappingTools:mainfrom
seisman:ci-allow-windows-pytest-segfault
Jun 5, 2026
Merged

CI: Allow Tests and Docs workflows to pass for segment fault on Windows#4664
seisman merged 3 commits into
GenericMappingTools:mainfrom
seisman:ci-allow-windows-pytest-segfault

Conversation

@seisman

@seisman seisman commented Jun 4, 2026

Copy link
Copy Markdown
Member

The Tests and Docs workflows are failing on Windows due to unknown crashes. Previously, we disable the Docs workflow on Windows CI in #4151, but we can't disable the Tests workflow on Windows CI.

This PR takes a different workaround and ignores the crash on Windows.

The changes will be reverted in #4156 so that we know if the workaround is still necessary for future GMT versions.

@seisman seisman changed the title ci: allow Windows pytest segfault exit code WIP: CI allow Windows pytest segfault exit code Jun 4, 2026
@seisman seisman force-pushed the ci-allow-windows-pytest-segfault branch 2 times, most recently from 7993522 to a206ed9 Compare June 4, 2026 08:00
@seisman seisman force-pushed the ci-allow-windows-pytest-segfault branch from a206ed9 to aa59acf Compare June 4, 2026 08:32
@seisman seisman changed the title WIP: CI allow Windows pytest segfault exit code CI: Allow Tests and Docs workflows to pass for segment fault on Windows Jun 4, 2026
log_file="${RUNNER_TEMP}/sphinx-html.log"
make -C doc clean html 2>&1 | tee "${log_file}"
exit_code=${PIPESTATUS[0]}
if [[ "${RUNNER_OS}" == "Windows" && "${exit_code}" -eq 2 ]] && grep -q "make: .* Error 2816" "${log_file}"; then

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make returns error code 2 with error message "Error 2816".

Comment thread .github/workflows/ci_docs.yml Outdated
Comment thread .github/workflows/ci_docs.yml
@seisman seisman added maintenance Boring but important stuff for the core devs needs review This PR has higher priority and needs review. labels Jun 4, 2026
@seisman seisman added this to the 0.19.0 milestone Jun 4, 2026
@seisman seisman merged commit a286249 into GenericMappingTools:main Jun 5, 2026
18 of 20 checks passed
@seisman seisman removed the needs review This PR has higher priority and needs review. label Jun 5, 2026
seisman added a commit that referenced this pull request Jun 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Boring but important stuff for the core devs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants