fix(build): write the binary to /server instead of stomping on /app#60
Merged
Conversation
`go build -o /app` writes the output binary into the existing /app directory (WORKDIR), then `COPY /app /app` brings the directory across, so the final image's /app is a *directory*. ENTRYPOINT ["/app"] then fails at runtime with: unable to start container process: error during container init: exec: "/app": is a directory Build only succeeded in the first place because docker-compose ran the service via `air` (live reload) and never exercised the production image. Surfacing now because k8s runs the image as-is. Switch to /server: produce a single binary file, COPY it directly, ENTRYPOINT points at the file. Same fix in core, oauth, discord.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
`go build -o /app` writes the output binary inside the existing `/app` directory (WORKDIR), then `COPY --from=builder /app /app` brings the directory across. The final image's `/app` is a directory, so `ENTRYPOINT ["/app"]` fails at runtime:
```
unable to start container process: error during container init:
exec: "/app": is a directory
```
This only surfaced now because k8s runs the production image directly — docker-compose dev mode uses `air` for live reload and skips the Dockerfile entrypoint entirely, so the bug hid.
Fix: build the binary to `/server` (a single file), COPY it across, point ENTRYPOINT at the file. Same in core, oauth, discord.