fix: @ file mention picker cannot be closed by clicking outside#879
Merged
Conversation
Add a document-level mousedown listener in FileMentionPicker that closes the picker when the user clicks anywhere outside the container. Previously the picker could only be dismissed via Escape, selecting an item, or editor blur — clicking the surrounding area had no effect. The listener uses capture phase to fire before editor blur handlers, and a containership check to avoid closing on clicks inside the picker.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
@file mention picker (FileMentionPicker) could not be dismissed by clicking outside the popup. Users could only close it via Escape, selecting an item, or editor blur.Fix
Added a document-level
mousedownlistener (capture phase) that closes the picker when the user clicks anywhere outside the container. UsescontainerRef.current.contains()to avoid closing on clicks inside the picker.Verification
pnpm run lint:web— passedpnpm run type-check:web— passed