-
-
Notifications
You must be signed in to change notification settings - Fork 51
Update Cotabby for single-sequence inference #803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+27
−16
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
max_prediction_tokenssilently dropped from C++ boundary config. The old call explicitly passedInt32(options.maxPredictionTokens)asmax_prediction_tokens; default-constructingSamplingConfig()leaves that field at its C++ aggregate zero-initialization default (0). The Swiftfor _ in 0 ..< options.maxPredictionTokensloop at line 373 is the authoritative budget owner and is unchanged, so this is fine as long assampleNextis stateless with respect tomax_prediction_tokens. If a future C++ revision adds an internal guard insampleNextthat reads the sequence's stored config limit and short-circuits on 0, every decode would silently produce zero tokens. Since the PR validates builds against both package revisions and the comment calls this field "never consumed," this is currently safe, but worth flagging for reviewers of the companion CotabbyInference change.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!