fix: #444, #437, #436, #435 - explicit return types in recurring.ts and aria-pressed on toggle buttons - #452
Open
abore9769 wants to merge 1 commit into
Open
fix: #444, #437, #436, #435 - explicit return types in recurring.ts and aria-pressed on toggle buttons#452abore9769 wants to merge 1 commit into
abore9769 wants to merge 1 commit into
Conversation
… explicit return types to recurring.ts and aria-pressed to toggle buttons closes FlowwStar#444 closes FlowwStar#437 closes FlowwStar#436 closes FlowwStar#435
|
@abore9769 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
void,void,number,RecurringRule) to the four exported functions inlib/recurring.tsthat were relying on inference, matching the convention already set bygetRecurringRules(): RecurringRule[].aria-pressed={statusFilter === f.value}to the status filter pills inapp/app/streams/page.tsx.aria-pressed={settings.strategy === opt.value}to the auto-withdraw strategy selector buttons inapp/app/stream/[id]/page.tsx.aria-pressed={settings.intervalHours === opt.hours}to the auto-withdraw frequency pills inapp/app/stream/[id]/page.tsx.Test plan
tsc --noEmit)/app/streamsreportaria-pressedcorrectly via browser accessibility tools/app/stream/[id]reportaria-pressedcorrectly/app/stream/[id]reportaria-pressedcorrectly when strategy istime-basedcloses #444
closes #437
closes #436
closes #435