fix: unit tests for deriveEvents, type=button, aria-label, aria-pressed (#433 #438 #439 #440) - #451
Open
observerr411 wants to merge 1 commit into
Open
fix: unit tests for deriveEvents, type=button, aria-label, aria-pressed (#433 #438 #439 #440)#451observerr411 wants to merge 1 commit into
observerr411 wants to merge 1 commit into
Conversation
…aria-label on stale-price emoji, aria-pressed on amount-mode toggle closes FlowwStar#433 closes FlowwStar#438 closes FlowwStar#439 closes FlowwStar#440
|
@observerr411 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
deriveEvents()in__tests__/hooks/use-activity-feed.test.ts: covers all four event types (created, withdrawal, cancelled, completed), verifiesrole(sent/received) for each, and asserts the correct description text.type="button"to the token filter buttons, status filter buttons, and clear-filters button inapp/app/streams/page.tsxto prevent accidental form submission.title="Price may be outdated"withrole="img" aria-label="Price may be outdated"on the stale-price warning emoji incomponents/streams/dashboard-stats.tsxfor reliable screen-reader announcement.aria-pressed={!usdInputMode}/aria-pressed={usdInputMode}to the token-amount / USD-amount toggle buttons inapp/app/create/create-form.tsxso screen readers can announce the active mode.Test plan
npm test— newderiveEventstests should all passtypearia-pressedstate changes