Skip to content

[2008] ui-text-input partial rendering when set to text area (multi-line) #2140

Merged
Steve-Mcl merged 3 commits into
mainfrom
2008-ui-text-input-fix
Jun 12, 2026
Merged

[2008] ui-text-input partial rendering when set to text area (multi-line) #2140
Steve-Mcl merged 3 commits into
mainfrom
2008-ui-text-input-fix

Conversation

@n-lark

@n-lark n-lark commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Description

In textarea (multi-line) mode, the global outlined-field rule that compresses input padding to 2px for compact single-line inputs left the floating label overlapping the first line of text. This restores adequate top/bottom padding scoped to the textarea only (single-line inputs keep their compact spacing), and adds a Cypress regression test asserting the padding isn't collapsed.

Related Issue(s)

Resolves #2008

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production
  • Link to Changelog Entry PR, or note why one is not needed.

Labels

  • Includes a DB migration? -> add the area:migration label

@n-lark n-lark requested review from hardillb and knolleary June 9, 2026 15:30
@n-lark n-lark self-assigned this Jun 9, 2026
@colinl

colinl commented Jun 9, 2026

Copy link
Copy Markdown
Collaborator

Can I ask whether you have checked it with compact row spacing in the theme?

@Steve-Mcl Steve-Mcl left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately this would cause misalignment with other widgets when anything other than default density is set on the theme.

For example, adding 3 text elements in a group and setting the density to compact, when this PR applies its styling, it affects adjacent widgets in the same group and causes misalignment with widgets in other groups.

BEFORE
Image

AFTER
Image

This is something the community will jump on immediately so needs a bit of a re-think.

@n-lark

n-lark commented Jun 11, 2026

Copy link
Copy Markdown
Contributor Author

Hey @Steve-Mcl I updated this so we now derive the padding and fade from --widget-row-height so it clears the label and scales per density without growing the row. The max() floors keep it valid if a sub-32px density is ever added.

// scoped to .nrdb-ui-textarea 

 --v-input-padding-top: max(4px, calc(var(--widget-row-height) / 2 - 12px));
    &.v-input .v-field--variant-outlined {
        --v-field-input-padding-top: max(4px, calc(var(--widget-row-height) / 2 - 12px));
        --v-field-input-padding-bottom: max(0px, calc(var(--widget-row-height) / 2 - 16px));
    }

Compact

Screenshot 2026-06-11 at 11 25 02 AM

Comfortable

Screenshot 2026-06-11 at 11 37 07 AM

Default

Screenshot 2026-06-11 at 11 26 47 AM

@n-lark n-lark requested a review from Steve-Mcl June 11, 2026 18:44

@Steve-Mcl Steve-Mcl left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

confirmed 👊

Image

@Steve-Mcl Steve-Mcl merged commit 66e3d50 into main Jun 12, 2026
4 checks passed
@Steve-Mcl Steve-Mcl deleted the 2008-ui-text-input-fix branch June 12, 2026 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ui-text-input partial rendering when set to text area (multi-line)

3 participants