Fix series images not loading through Reverse Proxy over HTTPS#191
Open
logicalChimp wants to merge 1 commit into
Open
Fix series images not loading through Reverse Proxy over HTTPS#191logicalChimp wants to merge 1 commit into
logicalChimp wants to merge 1 commit into
Conversation
encodeURIComponent the image URL passed to the /api/cached proxy endpoint. Without encoding, the raw '://' and path separators in the image URL were interpreted inconsistently by HTTPS servers and reverse proxies, causing the cached request to fail or be mangled. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
logicalChimp
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for changes:
I run Flexget behind an Nginx Proxy Manager reverse proxy, that provides SSL termination.
When I open Flexget Webui directly on the local network via ip-address/http, the thumbnails on the Series page load without issue.
When I open Flexget Webui via the DNS name (running through the reverse proxy), the thumbnails do not load.
Detailed changes:
encodeURIComponent the image URL passed to the /api/cached proxy endpoint.
Without encoding, the raw '://' and path separators in the image URL were interpreted inconsistently by HTTPS servers and reverse proxies, causing the cached request to fail or be mangled.
Addressed issues:
Implemented feature requests:
To Do: