Skip to content

Add OIDC client for fa-metrics#316

Open
FAUSheppy wants to merge 1 commit into
FAForever:developfrom
FAUSheppy:develop
Open

Add OIDC client for fa-metrics#316
FAUSheppy wants to merge 1 commit into
FAForever:developfrom
FAUSheppy:develop

Conversation

@FAUSheppy
Copy link
Copy Markdown

@FAUSheppy FAUSheppy commented Jun 1, 2026

Add a OIDC-Client for my Identity Broker to use for FA-Metrics.

Here is a overview of how I will use it for completeness:

Unbenanntes Diagramm drawio

Summary by CodeRabbit

  • New Features
    • Introduced FA Metrics as a new OAuth2 client, enabling secure API integration with support for authorization code and refresh token flows, offline access capabilities, and public profile data retrieval.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jun 1, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: ff0f68c3-adb1-4e24-abcb-01aa363f6d67

📥 Commits

Reviewing files that changed from the base of the PR and between 98c5322 and f56b34c.

📒 Files selected for processing (2)
  • apps/ory-hydra/templates/local-secret.yaml
  • apps/ory-hydra/values.yaml

📝 Walkthrough

Walkthrough

Adds a new "FA Metrics" OAuth2 client to Ory Hydra configuration, including the client definition with credentials, grant types, scopes, and redirect URIs in the Helm values, and the corresponding secret key in the Kubernetes Secret template.

Changes

FA Metrics OAuth2 Client

Layer / File(s) Summary
FA Metrics OAuth2 client and secret configuration
apps/ory-hydra/values.yaml, apps/ory-hydra/templates/local-secret.yaml
A new "FA Metrics" OAuth client is added to the Hydra clients list with authorization_code and refresh_token grant types, openid/offline/public_profile scopes, and client_secret_post token auth. The corresponding FA_METRICS_CLIENT_SECRET dummy secret is added to the local Kubernetes Secret template.

Possibly related PRs

  • FAForever/gitops-stack#312: Adds a different OAuth client (FAFTRACKER) using the same pattern of extending values.yaml with a new client entry and adding its corresponding secret to the local-secret template.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5 minutes


🐰 Hop, hop, hooray! A metrics client joins the crew,
With secrets safely bundled in Kubernetes true,
OAuth flows now richer, FA's vision grew—
Another hop forward in the digital zoo! 🌟

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Add OIDC client for fa-metrics' accurately and concisely describes the main change: adding a new OIDC client configuration for the fa-metrics service.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant