Skip to content

TJK: Defer lot/expiry control to receipt#16

Merged
bhavananarayanan merged 4 commits into
release/est/tjk/0.9.7from
feat/tjk/mandatory-lot-and-expiry-date-on-receipt
Jun 26, 2026
Merged

TJK: Defer lot/expiry control to receipt#16
bhavananarayanan merged 4 commits into
release/est/tjk/0.9.7from
feat/tjk/mandatory-lot-and-expiry-date-on-receipt

Conversation

@deeonwuli

Copy link
Copy Markdown

📌 References

📝 Implementation

  • Adds a config flag that defers lot/expiry requirements from inbound creation to the receiving step
  • When enabled, users can save an inbound movement without lot/expiry for controlled products, but those values are still required at receipt

🧪 Testing

  • Create an inbound movement with a product that has lot & expiry control enabled — leave lot and expiry blank and confirm you can proceed to the next step
  • Confirm that lot and expiry are still required at the receiving step for the same product
  • Create an inbound movement with a non-controlled product — confirm behaviour is unchanged
  • Disable the flag and confirm the original validation (lot/expiry required at creation) is restored

📸 Screenshots & Recordings (optional)

Screen.Recording.2026-06-16.at.16.06.07.mov

#869da1a55

@gqcorneby gqcorneby left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @deeonwuli! Works great :) Just one minor comment to reduce upstream touches and we're good.

Comment thread grails-app/conf/runtime.groovy Outdated
Constants.PRODUCT_INVENTORY_TRANSACTION_TYPE_ID,
Constants.INVENTORY_BASELINE_TRANSACTION_TYPE_ID
]

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can remove this to minimize upstream touches. It makes sense that the config defaults to false in ApiController since it's a custom one :)

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it

@gqcorneby

Copy link
Copy Markdown

Oh yeah! Maybe we can also archive the openspec for custom styles?

@deeonwuli

Copy link
Copy Markdown
Author

Oh yeah! Maybe we can also archive the openspec for custom styles?

All done!

@deeonwuli deeonwuli requested a review from gqcorneby June 17, 2026 13:11

@gqcorneby gqcorneby left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good! Great job @deeonwuli!

@bhavananarayanan bhavananarayanan merged commit b720473 into release/est/tjk/0.9.7 Jun 26, 2026
@bhavananarayanan bhavananarayanan deleted the feat/tjk/mandatory-lot-and-expiry-date-on-receipt branch June 26, 2026 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants