Skip to content

[No QA] [Test] Pin react-native-onyx to #806 — Failed to write blobs classification + instrumentation#95586

Draft
elirangoshen wants to merge 1 commit into
Expensify:mainfrom
callstack-internal:eliran/2397-idb-blob-write-errors-test
Draft

[No QA] [Test] Pin react-native-onyx to #806 — Failed to write blobs classification + instrumentation#95586
elirangoshen wants to merge 1 commit into
Expensify:mainfrom
callstack-internal:eliran/2397-idb-blob-write-errors-test

Conversation

@elirangoshen

@elirangoshen elirangoshen commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Explanation of Change

Companion / verification PR for react-native-onyx PR Expensify/react-native-onyx#806. It pins react-native-onyx to that PR's HEAD via git+https so E/App CI and manual testing exercise the change before the Onyx PR is merged and published.

The Onyx change addresses DataError: Failed to write blobs, which has grown from 1.9% to ~93% of all Onyx web storage errors (#87871). Chromium externalizes any IndexedDB value >64 KB into a blob file; when that write fails the error was unclassified, so Onyx retried it 5× (prod shows ~99.7% futile) and logged ~6× per failure before silently dropping the write. The Onyx PR classifies it as a new UNRECOVERABLE class (skip quietly — no retry/throw/eviction) and adds a log-only diagnostic that reports the failing key(s) + approximate serialized size, so we can confirm the >64 KB trigger and identify the culprit keys.

Pin: "react-native-onyx": "git+https://github.com/callstack-internal/react-native-onyx.git#9b9aba708a408af226563deff6add1e6035e9ea0".

⚠️ Not for merge as-is: once Onyx PR #806 merges and publishes, repin to the released version (e.g. "react-native-onyx": "3.0.xx") — at which point this becomes the bump PR.

Fixed Issues

$ #87871
PROPOSAL:

Tests

This is a library-only bump with no user-facing UI change; the goal is to confirm no regressions in normal Onyx read/write behavior and that the new classification behaves correctly. The underlying Chromium blob-write failure can't be reproduced on demand, so:

  1. Launch the web app, log in, and use the app normally (open chats/reports, create an expense, switch workspaces). Verify everything loads and persists across reloads as before.
  2. Verify no new JS console errors appear during normal use.
  3. (Behavior check) In a local build, temporarily make an IndexedDB write reject with new DOMException('Failed to write blobs (IOError)', 'DataError') and confirm:
    • the operation is not retried 5× (previously it was),
    • a single Storage operation skipped retry; unrecoverable errors cannot be recovered by retrying … log line appears, followed by the pairs: … over64KB: … largest: […] payload summary,
    • no Attempted to set invalid data … throw, no eviction, and no IDB heal … reopen logs for this error,
    • normal (small, successful) writes are unaffected.
  • Verify that no errors appear in the JS console

Offline tests

  1. Go offline, perform actions that write to Onyx (e.g. draft a message, create an expense). Verify optimistic data is stored and the UI updates as expected.
  2. Go back online and verify the queued changes sync normally. No change from current behavior is expected — the Onyx change only affects how an unrecoverable IndexedDB blob-write failure is handled.

QA Steps

Same as tests. No user-facing behavior changes; this is an Onyx library bump. (Title should include "[No QA]" if QA is not required.)

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

Test-only branch: pins react-native-onyx to
callstack-internal/react-native-onyx@9b9aba70
(eliran/2397-classify-idb-blob-write-errors) so the "Failed to write blobs"
classification fix + failing-write instrumentation can be exercised in the App.
Not for merge.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant