Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 44 additions & 0 deletions src/typeScriptImportGraphAnalysis.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -220,4 +220,48 @@ describe("TypeScript import graph analysis", () => {
]);
expect(graph.hubs.map((hub) => hub.filePath)).toEqual(["src/index.ts", "src/real.ts"]);
});

it("classifies Node built-ins as external imports", () => {
const projectRoot = makeTempProject("node-builtins");
writeTypeScriptProject(projectRoot, {
"src/index.ts": [
"import fs from 'node:fs';",
"import path from 'path';",
"export { readFile } from 'node:fs/promises';",
"export const modules = [fs, path];",
"",
].join("\n"),
});

const graph = analyzeTypeScriptImportGraph({
projectRoot,
include: ["src/**/*.ts"],
});

expect(graph.status).toBe("ok");
expect(graph.summary).toMatchObject({
moduleCount: 1,
edgeCount: 0,
unresolvedImportCount: 0,
externalImportCount: 3,
});
expect(graph.unresolvedImports).toEqual([]);
expect(graph.externalImports).toEqual([
{
from: "src/index.ts",
specifier: "node:fs",
kind: "import",
},
{
from: "src/index.ts",
specifier: "node:fs/promises",
kind: "export",
},
{
from: "src/index.ts",
specifier: "path",
kind: "import",
},
]);
});
});
19 changes: 18 additions & 1 deletion src/typeScriptImportGraphAnalysis.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { createRequire } from "node:module";
import { builtinModules, createRequire } from "node:module";
import path from "node:path";
import type { NexusPluginMcpServerCapability } from "dev-nexus";
import {
Expand All @@ -25,6 +25,11 @@ const defaultIncludePatterns = [
"src/**/*.cts",
];

const nodeBuiltinSpecifiers = new Set([
...builtinModules,
...builtinModules.map((moduleName) => `node:${moduleName}`),
]);

export const typeScriptImportGraphToolDescriptors = [
{
name: "typescript.importGraph",
Expand Down Expand Up @@ -466,6 +471,14 @@ function buildImportGraph(input: {
moduleResolutionCache,
});
if (!resolved) {
if (isNodeBuiltinSpecifier(reference.specifier)) {
externalImports.push({
from: reference.from,
specifier: reference.specifier,
kind: reference.kind,
});
continue;
}
unresolvedImports.push({
from: reference.from,
specifier: reference.specifier,
Expand Down Expand Up @@ -606,6 +619,10 @@ function resolveImportReference(input: {
);
}

function isNodeBuiltinSpecifier(specifier: string): boolean {
return nodeBuiltinSpecifiers.has(specifier);
}

function graphModules(
filePaths: string[],
edges: TypeScriptImportGraphEdge[],
Expand Down
Loading