fix: throw an exception when an http request takes more than 5s#11
Open
oliverpool wants to merge 1 commit into
Open
fix: throw an exception when an http request takes more than 5s#11oliverpool wants to merge 1 commit into
oliverpool wants to merge 1 commit into
Conversation
When a server only listens on port 443, an http request on port 80 will hang forever, preventing the test from going further.
Member
|
I'm putting this on my TODO list; I like the idea, but I seem to remember that some authorization servers in our survey waited more than 5 seconds after which they successfully completed the request (presumably as part of a DoS-protection/anti-brute-force mechanism). So instead of just killing the connection after 5 seconds, I'm thinking of making this a configurable option via the site settings... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a server only listens on port 443, an http request on port 80 will hang forever, preventing the test from going further.
Disclaimer: I have very little experience with C#/.NET and used an LLM to recommend a fix.