Skip to content

changed from suffix to name in _update_macros #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adedamola-sode merged 2 commits into from
Jul 1, 2026
Merged

changed from suffix to name in _update_macros #248

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f7e954e
changed from suffix to name in _update_macros
adedamola-sode Jun 30, 2026
802c1e5
used component_name instead of duplicating code
adedamola-sode Jul 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/techui_builder/generate.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,8 +165,8 @@ def _update_macros(self, component: Entity) -> tuple[str, dict[str, str]]:
# Try to get name from child labels if they exist,
# if not, just use the name as it is.
if component.child_labels is not None:
if suffix in component.child_labels.keys():
component_name = component.child_labels[suffix]
if component_name in component.child_labels.keys():
component_name = component.child_labels[component_name]
self.label_flag = True

prefix_key = next(k for k, v in component.macros.items() if v == prefix)
Expand Down
2 changes: 1 addition & 1 deletion tests/test_generate.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,7 @@ def test_generator_update_macros_suffix_with_child_labels(generator):
desc=None,
service_name="bl01t-mo-test-01",
macros={"P": "TEST", suffix_key: suffix},
child_labels={suffix: child_label},
child_labels={"T1": child_label},
)

component_name, updated_macros = generator._update_macros(component)
Expand Down