feat(api): add PageBackgroundFill band factory helpers#76
Merged
Conversation
Adds topBand, bottomBand, band, topBandPoints, and bandPoints factory methods for full-width horizontal background bands (top, bottom, or an arbitrary vertical offset; ratio- or point-based), complementing the existing column helpers and building on the v1.6.5 y-coordinate fix. Includes ratio-equality and render-placement tests plus a CHANGELOG entry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds full-width horizontal-band factory helpers to
PageBackgroundFill, built on the v1.6.5 y-coordinate fix (#75).New API
topBand(heightRatio, color)— band flush with the page topbottomBand(heightRatio, color)— band flush with the page bottomband(yRatioFromTop, heightRatio, color)— band at an arbitrary vertical offsettopBandPoints(heightPoints, pageHeight, color)/bandPoints(yFromTopPoints, heightPoints, pageHeight, color)— point-based convenienceComplements the existing
fullPage/leftColumn/rightColumn/columnhelpers.Test plan
bandFactoryHelpersComputeRatiosCorrectly— ratio + points conversiontopBandAndBottomBandHelpersRenderAtCorrectEdges— end-to-end placement (top → y=252, bottom → y=0 at H=300)PageBackgroundTest15/15mvnw clean verify -pl .— 999 tests, 0 failuresjavadoc:javadocclean (new{@link}refs resolve)Completes the v1.6.5 engine work (audit §4.6 / R5).