fix(models): correct lucy-2.5 resolution (720p) and realtime fps#60
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Corrects the
lucy-2.5model metadata so it reflects the model's actual output. It now reports 1280×720 for both realtime and video, and realtime runs at 30fps (video stays at 20fps).Why
lucy-2.5is a 720p, 30fps-realtime model, but the SDK was reporting the older Lucy sizing (1088×624) and a 20fps realtime rate. Anyone reading these values — or relying on them to size their capture/render pipeline — was getting the wrong resolution and frame rate.Usage
Note
Low Risk
Metadata-only registry and test changes; realtime fps alignment may change LiveKit timing for existing
lucy-2.5integrations that relied on the old 20fps value.Overview
Updates
lucy-2.5registry metadata so it matches the model’s real output instead of legacy Lucy 2.1 sizing.For realtime (
models.realtime("lucy-2.5")), fps goes from 20 → 30 and dimensions from 1088×624 → 1280×720. For video jobs (models.video("lucy-2.5")), only resolution changes to 1280×720; job fps stays at 20.Tests in
test_models.pyare updated to assert the new values. Because the realtime client wiresmodel.fpsinto LiveKit, this also corrects frame-rate configuration forlucy-2.5streams.Reviewed by Cursor Bugbot for commit a8756e6. Bugbot is set up for automated code reviews on this repo. Configure here.