Fix tour styles#701
Open
Creylay wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed several visual inconsistencies in the tour/tutorial system that appeared in light mode and across both themes. The main issues were: hardcoded dark backgrounds in tip boxes that broke in light mode, a spotlight border that was invisible or the wrong color in light mode due to incorrect handling of Joyride's
mix-blend-mode: hard-lightoverlay, and an overly intense interactive step pulse animation.Type of Change
Changes (by file)
front/src/components/tour/TourProvider.jsx: ReplacedhardLightInverse(computed only for dark backgrounds) with a mode-awarehlInverse(color, isDark)that correctly inverts the primary color through Joyride'smix-blend-mode: hard-lightoverlay —(255+x)/2for dark pages,x/2for light pages. Reduced pulse animation intensity and speed, and added a subtle glow to distinguish interactive steps from non-interactive ones in light mode.front/src/constants/tours/datasetsTour.js: Updated download button color from legacy orange (#ef9f27) to primary blue (#2C7AFF). Replaced hardcoded dark green tip boxes (#1b2f26,color: white) with semi-transparent green (rgba(76, 175, 80, 0.12),color: inherit) so they render correctly in both themes.front/src/constants/tours/notebookTour.js: Same tip box fix asdatasetsTour.js.front/src/constants/tours/experimentsTour.js: Replaced light-only hardcoded backgrounds (#e3f2fd,#fff3e0,#f0f9ff) with semi-transparent equivalents. Added left border accents to match the tip box style used in other tours.front/src/constants/tours/modelsTour.js: Replaced dark-only text colors (#2e7d32,#d32f2f) with mid-brightness alternatives (#43A047,#e53935) readable on both light and dark dialog backgrounds. Changedcolor: #666tocolor: inherit.Testing