feat(core): add AsyncCacheableSource and cacheable-source wiring#938
Open
chrisburr wants to merge 2 commits into
Open
feat(core): add AsyncCacheableSource and cacheable-source wiring#938chrisburr wants to merge 2 commits into
chrisburr wants to merge 2 commits into
Conversation
5 tasks
Contributor
|
Why is this still a draft? The blocking PR has been merged. @Loxeris I assigned you as reviewer. |
chrisburr
force-pushed
the
rss-3-cacheable-source
branch
from
974be41 to
e24e414
Compare
Member
Author
|
It needed rebasing, done now. |
Loxeris
reviewed
Jun 18, 2026
Adds a generic diracx.core.sources module with AsyncCacheableSource and Snapshot, a diracx.cacheable_sources entry-point group, and application factory support: each source is instantiated once per app (so its caches persist across requests) with the database instance matching its db_class, and its read method overrides the create dependency for every implementation class so extensions can substitute their own sources. Routers depending on a source whose database is not available fail at startup, consistent with the handling of missing databases. Co-authored-by: Loxeris <30194187+Loxeris@users.noreply.github.com>
Co-locate the sync CacheableSource base class with its async sibling AsyncCacheableSource in diracx.core.sources, leaving diracx.core.config.sources to hold only config-specific sources. CacheableSource is fully generic and only lived in the config module for historical reasons. diracx.core.config still re-exports CacheableSource, so existing imports keep working.
chrisburr
force-pushed
the
rss-3-cacheable-source
branch
from
32fe963 to
8cf3bd6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a generic
diracx.core.sourcesmodule withAsyncCacheableSourceandSnapshot, adiracx.cacheable_sourcesentry-point group, and applicationfactory support: each source is instantiated once per app (so its caches
persist across requests) with the database instance matching its
db_class, and its read method overrides the create dependency for everyimplementation class so extensions can substitute their own sources.
Routers depending on a source whose database is not available fail at
startup, consistent with the handling of missing databases.
Replaces #910
Part of #839
Blocked by #936