feat(marketplace): system-admin allow-list management UI#8506
Open
LWS49 wants to merge 1 commit into
Open
Conversation
LWS49
force-pushed
the
lws49/feat-marketplace-pr6b-backend
branch
from
July 22, 2026 05:22
c1b9c90 to
b0b796d
Compare
LWS49
force-pushed
the
lws49/feat-marketplace-pr6c-allowlist
branch
from
July 22, 2026 05:35
88a233d to
c02489f
Compare
LWS49
force-pushed
the
lws49/feat-marketplace-pr6b-backend
branch
from
July 22, 2026 05:40
b0b796d to
c7e43f9
Compare
LWS49
force-pushed
the
lws49/feat-marketplace-pr6c-allowlist
branch
2 times, most recently
from
July 22, 2026 05:54
dcd6d34 to
1b71da5
Compare
System::Admin page to manage the marketplace allow-list: add/remove typed rules (specific user, whole instance, or email domain) with a live preview of who each rule would let in, and an open-to-everyone / restrict toggle.
LWS49
force-pushed
the
lws49/feat-marketplace-pr6c-allowlist
branch
from
July 22, 2026 06:01
1b71da5 to
0234290
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the System::Admin page for managing marketplace access rules. It lists the current typed rules, adds them through a two-step dialog that previews exactly who a rule would let in before it is saved, and carries an open-to-everyone / restrict toggle. The page is reachable from a new Marketplace Access entry in the admin navigator, and consumes the endpoints from the backend PR.
Design decisions
@nus.edu.sgwithout seeing who it actually reaches.lib/- the only other instance picker in the codebase belongs to course duplication, and keeping this feature's UI self-contained means it can be reverted by deleting its own files.Regression prevention
Covers: lazy single-fetch of the instance list, the preview request and render for each rule type, the counts line with and without the blocked and already-has-access clauses, the blocked marker, an empty preview, rule table rendering and deletion, the mode banner and its confirmation dialogs, and the index page's fetch, create, delete and toggle flows including failure toasts.