Potential fix for code scanning alert no. 5: DOM text reinterpreted as HTML#61
Draft
LaxentaInc wants to merge 1 commit into
Draft
Potential fix for code scanning alert no. 5: DOM text reinterpreted as HTML#61LaxentaInc wants to merge 1 commit into
LaxentaInc wants to merge 1 commit into
Conversation
…s HTML Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| <div key={i} className="relative w-16 h-16 rounded border border-[#30363d] overflow-hidden group"> | ||
| {/* CodeQL fix: sanitize image src */} | ||
| <img src={typeof src === 'string' && (src.startsWith('blob:') || src.startsWith('data:') || src.startsWith('http')) ? src : ''} alt="" className="w-full h-full object-cover" /> | ||
| <img src={getSafeImagePreviewSrc(src)} alt="" className="w-full h-full object-cover" /> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/Colorwall/Colorwall-Site/security/code-scanning/5
General fix: avoid permissive string-prefix checks and instead perform strict URL/scheme validation at render time (or, better, store only trusted object URLs generated by your code). Since this component creates previews from local files, the safest no-functional-change fix is to allow only
blob:and (optionally) constrained imagedata:URLs, and reject everything else.Best single fix in this file:
src/app/components/FeedbackCards.tsx, replace the inlinesrcternary on line 390 with a helper function call.getSafeImagePreviewSrc(src: string): stringthat:''unlesssrcis a string,blob:URLs,data:image/...;base64,...URLs via regex,http/httpsand other schemes for previews (not needed for local upload previews).This preserves current behavior for uploaded previews and removes weak scheme checks.
Suggested fixes powered by Copilot Autofix. Review carefully before merging.