Skip to content

Cape Town | May-ITP-26 | Enice Mutanda | Sprint 2 | WireFrame#1359

Open
Enice-Codes wants to merge 1 commit into
CodeYourFuture:mainfrom
Enice-Codes:Feature/Wireframe
Open

Cape Town | May-ITP-26 | Enice Mutanda | Sprint 2 | WireFrame#1359
Enice-Codes wants to merge 1 commit into
CodeYourFuture:mainfrom
Enice-Codes:Feature/Wireframe

Conversation

@Enice-Codes
Copy link
Copy Markdown

@Enice-Codes Enice-Codes commented May 27, 2026

Learners, PR Template

Self checklist

[× ]titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title

[ ×] My changes meet the requirements of the task

[ ×] I have tested my changes

[× ] My changes follow the style guide

Changelist

  • Changed image
  • fixed footer positioning
  • used CSS Grid to style layout
  • Added semantic HTML structure
  • Improved layout

Questions

I do not have any questions

@netlify
Copy link
Copy Markdown

netlify Bot commented May 27, 2026

Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit 8a70e00
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/6a1ad1d6e989f7000835282f
😎 Deploy Preview https://deploy-preview-1359--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
2 paths audited
Performance: 90 (🔴 down 10 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 86 (no change from production)
PWA: -
View the detailed breakdown and full score reports
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions

This comment has been minimized.

1 similar comment
@github-actions

This comment has been minimized.

@Enice-Codes Enice-Codes added 🏕 Priority Mandatory This work is expected 📅 Sprint 2 Assigned during Sprint 2 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels May 27, 2026
@github-actions

This comment has been minimized.

2 similar comments
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 27, 2026
@Enice-Codes Enice-Codes added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 27, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 27, 2026
@github-actions

This comment has been minimized.

@Enice-Codes Enice-Codes added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 27, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 27, 2026
@Enice-Codes Enice-Codes reopened this May 27, 2026
@github-actions

This comment has been minimized.

1 similar comment
@github-actions

This comment has been minimized.

@Enice-Codes Enice-Codes added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 27, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 27, 2026
@Enice-Codes Enice-Codes added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 28, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 28, 2026
@github-actions

This comment has been minimized.

2 similar comments
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

1 similar comment
@github-actions

This comment has been minimized.

@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 28, 2026
@Enice-Codes Enice-Codes added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 29, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 29, 2026
@Enice-Codes Enice-Codes added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 29, 2026
@Enice-Codes Enice-Codes changed the title Cape Town| May-ITP-26 | Enice Mutanda | Sprint 2 | WireFrame Cape Town | May-ITP-26 | Enice Mutanda | Sprint 2 | WireFrame May 29, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 29, 2026
@github-actions

This comment has been minimized.

@Enice-Codes Enice-Codes added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 29, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 29, 2026
@Enice-Codes Enice-Codes added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 29, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 29, 2026
@github-actions

This comment has been minimized.

@Enice-Codes Enice-Codes added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 29, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 29, 2026
@Enice-Codes Enice-Codes added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 30, 2026
@cjyuan cjyuan added the Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. label May 30, 2026
@cjyuan
Copy link
Copy Markdown
Contributor

cjyuan commented May 30, 2026

image

The checkboxes in the PR description are not yet correctly checked in Markdown syntax. Can you fix them?
To learn more about GitHub tasklist (list of check boxes), please refer to this article:
https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/about-tasklists

Copy link
Copy Markdown
Contributor

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • According to https://validator.w3.org/, there are errors in your code. Can you fix them?

  • One of the acceptance criteria, "The page footer is fixed to the bottom of the viewport", has not yet been satisfied. Can you make the necessary change? (Suggestion: Ask AI what that requirement means).

  • Good progress on the page layout. To better match the wireframe, can you center the text beneath the title? (In the wireframe, the "A SHORT DESCRIPTION" beneath the page title is centered.)

Comment thread Wireframe/index.html
Comment on lines +45 to +48
<article>
<img src="images/image3.jpg" alt="" />
<h2>What is a branch?</h2>
<p>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation is off.

As a best practice, consider following this guide to enable VS Code's
"Format on Save" option or to use its "Format Document" command to ensure your code is always consistently formatted.

Comment thread Wireframe/style.css
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are two main selectors in this file. Consider merging the properties from both selectors into a single main rule to make them easier to find and maintain.

Comment thread Wireframe/index.html
</article>

<article>
<img src="images/image2.jpg" alt="" />
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Providing meaningful alt text is important because it ensures images are accessible to people using screen readers and also helps when images
fail to load, giving users essential context about the content or function of the image.

Can you give a more descriptive alt value to all images?

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels May 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Module-Onboarding The name of the module. 🏕 Priority Mandatory This work is expected Reviewed Volunteer to add when completing a review with trainee action still to take. 📅 Sprint 2 Assigned during Sprint 2 of this module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants