Cape Town | May-ITP-26 | Enice Mutanda | Sprint 2 | WireFrame#1359
Cape Town | May-ITP-26 | Enice Mutanda | Sprint 2 | WireFrame#1359Enice-Codes wants to merge 1 commit into
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
2 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
2 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
5446b30 to
8a70e00
Compare
The checkboxes in the PR description are not yet correctly checked in Markdown syntax. Can you fix them? |
cjyuan
left a comment
There was a problem hiding this comment.
-
According to https://validator.w3.org/, there are errors in your code. Can you fix them?
-
One of the acceptance criteria, "The page footer is fixed to the bottom of the viewport", has not yet been satisfied. Can you make the necessary change? (Suggestion: Ask AI what that requirement means).
-
Good progress on the page layout. To better match the wireframe, can you center the text beneath the title? (In the wireframe, the "A SHORT DESCRIPTION" beneath the page title is centered.)
| <article> | ||
| <img src="images/image3.jpg" alt="" /> | ||
| <h2>What is a branch?</h2> | ||
| <p> |
There was a problem hiding this comment.
Indentation is off.
As a best practice, consider following this guide to enable VS Code's
"Format on Save" option or to use its "Format Document" command to ensure your code is always consistently formatted.
There was a problem hiding this comment.
There are two main selectors in this file. Consider merging the properties from both selectors into a single main rule to make them easier to find and maintain.
| </article> | ||
|
|
||
| <article> | ||
| <img src="images/image2.jpg" alt="" /> |
There was a problem hiding this comment.
Providing meaningful alt text is important because it ensures images are accessible to people using screen readers and also helps when images
fail to load, giving users essential context about the content or function of the image.
Can you give a more descriptive alt value to all images?


Learners, PR Template
Self checklist
[× ]titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
[ ×] My changes meet the requirements of the task
[ ×] I have tested my changes
[× ] My changes follow the style guide
Changelist
Questions
I do not have any questions