Skip to content

London | 26-ITP-May | Risikat Popoola | Sprint 1 | Form Controls #1351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
risikatpopoola wants to merge 6 commits into
base: main
Choose a base branch
from
+100 −15
Open

London | 26-ITP-May | Risikat Popoola | Sprint 1 | Form Controls #1351

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d55dd23
name, email and color fields added
risikatpopoola May 19, 2026
dcc5e0b
size field added
risikatpopoola May 19, 2026
5bb4747
footer paragraph changed
risikatpopoola May 19, 2026
626f08c
final edit
risikatpopoola May 25, 2026
d0003e4
final edit to text for accesibilty
risikatpopoola May 25, 2026
75ba07b
another edit for accessibility
risikatpopoola May 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
115 changes: 100 additions & 15 deletions Form-Controls/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,22 +6,107 @@
<title>My form exercise</title>
<meta name="description" content="" />
<meta name="viewport" content="width=device-width, initial-scale=1" />
<style>
h1{
color:rgb(127, 24, 175);
font-family:serif;
Comment on lines +9 to +12
Copy link
Copy Markdown
Contributor

@cjyuan cjyuan May 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider moving the CSS into an external .css file instead of embedding them within the HTML document.
This improves maintainability, keeps the markup cleaner, and makes it easier to locate, update, and reuse styles across multiple pages.

font-size:60px;
text-align: left;
font-style: oblique;
}
label{
font-size: 22px;
color: rgb(29, 45, 133);
}
h2{
font-size: 25px;
color: rgb(127, 24, 175);;
}
#wall{
background-color:rgb(160, 243, 243);
padding:6px 6px;
border: 6px solid black;
max-width:70%;
margin: 3px auto;
}
footer{
font-family: Arial, Helvetica, sans-serif;
font-size: 20px;
text-align: center;
}
</style>
</head>
<body>
<header>
<h1>Product Pick</h1>
</header>
<main>
<form>
<!-- write your html here-->
<!--
try writing out the requirements first as comments
this will also help you fill in your PR message later-->
</form>
</main>
<footer>
<!-- change to your name-->
<p>By HOMEWORK SOLUTION</p>
</footer>
<div id="wall">
<header>
<h1>Product Pick</h1>
</header>
<main>
<form>
<!-- write your html here-->
<!--What is the customer's name? I must collect this data and ensure it contains at least two non-space characters.
What is the customer's email? I must make sure the email is valid. Email addresses follow a consistent pattern.
What colour should this T-shirt be? I must provide 3 options. How will I ensure they do not choose other colours?
What size does the customer want? I must provide the following 6 options: XS, S, M, L, XL, XXL-->
<div>
<label for="name">Name:</label>
<input type="text" id="name" name="name" pattern=".*\S.*\S.*" required title="Please enter at least two non-space characters">
</div>
<div>
<label for="email">Email</label>
<input type="email" id="email" name="email" required>
</div>
<div>
<h2>COLOR</h2>
<div>
<label for="purple">Purple</label>
<input type="radio" name="color" id="purple" value="purple">
</div>
<div>
<label for="blue">Blue</label>
<input type="radio" name="color" id="blue" value="blue">
</div>
<div>
<label for="wine">Wine</label>
<input type="radio" name="color" id="wine" value="wine">
</div>
</div>
<div>
<h2>SIZE</h2>
<div>
<label for="extrasmall">XS</label>
<input type="radio" name="size" id="extrasmall" value="xs">
</div>
Comment on lines +76 to +79
Copy link
Copy Markdown
Contributor

@cjyuan cjyuan May 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Could you use an AI tool to research the advantages and disadvantages of placing radio buttons on the left versus the right of their corresponding labels?

  • Could consider this alternate syntax so that you don't have to introduce the id attribute.

              <label>
            <input type="radio" name="size" value="xs"> 
            XS
          </label>

<div>
<label for="small">S</label>
<input type="radio" name="size" id="small" value="s">
</div>
<div>
<label for="medium">M</label>
<input type="radio" name="size" id="medium" value="m">
</div>
<div>
<label for="large">L</label>
<input type="radio" name="size" id="large" value="l">
</div>
<div>
<label for="extralarge">XL</label>
<input type="radio" name="size" id="extralarge" value="xtralarge">
Copy link
Copy Markdown
Contributor

@cjyuan cjyuan May 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make the value of this value attribute more consistent?

</div>
<div>
<label for="doubleextralarge">XXL</label>
<input type="radio" name="size" id="doubleextralarge" value="xxl">
</div>
<div>
<button type="submit">Submit</button>
</div>
</div>
</form>
</main>
<footer>
<!-- change to your name-->
<p>Rizqah Popoola</p>
</footer>
</div>
</body>
</html>
Empty file added Form-Controls/styles.css
View file
Open in desktop
Empty file.
Loading