fix(aspacem): raise amd64 managed address ceiling to 1 TiB#22
Conversation
7d8cb8b to
5714dad
Compare
Greptile SummaryThis PR bundles two related fixes for CodSpeed's ARM64 CI environment: it raises the amd64
Confidence Score: 5/5Both the address-space ceiling increase and the Cortex-A72 LLSC fallback detection are targeted, well-bounded changes with no regressions for other platforms; safe to merge. The amd64 aspacem_maxAddr increase to 1 TiB stays well inside the 47-bit user VA limit, and the ENABLE_INNER clamp is preserved. The Cortex-A72 detection adds a compound AND condition that is safe-direction on a false positive. CI additions are consistent with existing patterns and LFS is already enabled. No files require special attention. Important Files Changed
Reviews (2): Last reviewed commit: "fix(aspacem): raise amd64 managed addres..." | Re-trigger Greptile |
snmalloc-rs as a global allocator aborts under Callgrind because its startup mmap of a flat 256 GiB MAP_NORESERVE range returns EINVAL. On amd64-linux the address-space manager capped the managed range at 128 GiB, placing vStart (the client/Valgrind split) at ~64 GiB, so the largest floating client hole was ~62 GiB and any larger reservation was vetoed by VG_(am_get_advisory). Raise aspacem_maxAddr to 1 TiB (vStart ~512 GiB, ~512 GiB client hole), scoped to VGP_amd64_linux so other 64-bit ports keep 128 GiB (some arm64 kernels expose only a 39-bit user VA). No effect on Callgrind placement semantics; the fork ships only the 64-bit Callgrind tool. Refs COD-3073
5714dad to
5dc8a71
Compare
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [CodSpeedHQ/action](https://redirect.github.com/CodSpeedHQ/action) | action | patch | `v4.18.4` → `v4.18.5` | --- > [!WARNING] > Some dependencies could not be looked up. Check the [Dependency Dashboard](../issues/5322) for more information. --- ### Release Notes <details> <summary>CodSpeedHQ/action (CodSpeedHQ/action)</summary> ### [`v4.18.5`](https://redirect.github.com/CodSpeedHQ/action/releases/tag/v4.18.5) [Compare Source](https://redirect.github.com/CodSpeedHQ/action/compare/v4.18.4...v4.18.5) #### Release Notes ##### <!-- 10 -->💼 Other - Bump pinned valgrind-codspeed to [3.26.0-0codspeed6](https://redirect.github.com/CodSpeedHQ/valgrind-codspeed/releases/tag/3.26.0-0codspeed6) ([#​448](https://redirect.github.com/CodSpeedHQ/action/issues/448)) by [@​adriencaccia](https://redirect.github.com/adriencaccia) in [#​448](https://redirect.github.com/CodSpeedHQ/runner/pull/448) - fix: hangs on ARM64 due to atomics by [@​not-matthias](https://redirect.github.com/not-matthias) in [CodSpeedHQ/valgrind-codspeed#23](https://redirect.github.com/CodSpeedHQ/valgrind-codspeed/pull/23) - fix(aspacem): raise amd64 managed address ceiling to 1 TiB by [@​not-matthias](https://redirect.github.com/not-matthias) in [CodSpeedHQ/valgrind-codspeed#22](https://redirect.github.com/CodSpeedHQ/valgrind-codspeed/pull/22) #### Install codspeed-runner 4.18.4 ##### Install prebuilt binaries via shell script ```sh curl --proto '=https' --tlsv1.2 -LsSf https://github.com/CodSpeedHQ/codspeed/releases/download/v4.18.4/codspeed-runner-installer.sh | sh ``` #### Download codspeed-runner 4.18.4 | File | Platform | Checksum | | ----------------------------------------------------------------------------------------------------------------------------------------------------------------------- | ------------------- | ------------------------------------------------------------------------------------------------------------------------------------- | | [codspeed-runner-aarch64-apple-darwin.tar.gz](https://redirect.github.com/CodSpeedHQ/codspeed/releases/download/v4.18.4/codspeed-runner-aarch64-apple-darwin.tar.gz) | Apple Silicon macOS | [checksum](https://redirect.github.com/CodSpeedHQ/codspeed/releases/download/v4.18.4/codspeed-runner-aarch64-apple-darwin.tar.gz.sha256) | | [codspeed-runner-aarch64-unknown-linux-musl.tar.gz](https://redirect.github.com/CodSpeedHQ/codspeed/releases/download/v4.18.4/codspeed-runner-aarch64-unknown-linux-musl.tar.gz) | ARM64 MUSL Linux | [checksum](https://redirect.github.com/CodSpeedHQ/codspeed/releases/download/v4.18.4/codspeed-runner-aarch64-unknown-linux-musl.tar.gz.sha256) | | [codspeed-runner-x86\_64-unknown-linux-musl.tar.gz](https://redirect.github.com/CodSpeedHQ/codspeed/releases/download/v4.18.4/codspeed-runner-x86_64-unknown-linux-musl.tar.gz) | x64 MUSL Linux | [checksum](https://redirect.github.com/CodSpeedHQ/codspeed/releases/download/v4.18.4/codspeed-runner-x86_64-unknown-linux-musl.tar.gz.sha256) | **Full Runner Changelog**: <https://github.com/CodSpeedHQ/codspeed/blob/main/CHANGELOG.md> **Full Changelog**: <CodSpeedHQ/action@v4.18.4...v4.18.5> </details> --- ### Configuration 📅 **Schedule**: (UTC) - Branch creation - At any time (no schedule defined) - Automerge - At any time (no schedule defined) 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/open-telemetry/opentelemetry-go). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My4yNDIuMiIsInVwZGF0ZWRJblZlciI6IjQzLjI0Mi4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJTa2lwIENoYW5nZWxvZyIsImRlcGVuZGVuY2llcyJdfQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Raises amd64
aspacem_maxAddrfrom 128 GiB to 1 TiB so a client can float a 256 GiBMAP_NORESERVEreservation (e.g. snmalloc) under Callgrind instead of gettingEINVAL. Scoped toVGP_amd64_linux.Refs COD-3073