fix: properly check for TTY support#19
Merged
Merged
Conversation
…er the given file descriptor is a terminal or not
Owner
Author
|
had a bug where sometimes the program could determine properly that the file desc was terminal and it supported TTY and sometimes it would fail to determine that. it turns out the root cause was os.Stdin.Stat() in the root.go file, it checked filesystem mode bits, which , now i found out that don't reliably indicate a TTY. The fix switches to term.IsTerminal() from the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.