fix(clickstack-operators): bump clickhouse-operator-helm dep to >=0.0.5#226
Open
ZeynelKoca wants to merge 1 commit into
Open
fix(clickstack-operators): bump clickhouse-operator-helm dep to >=0.0.5#226ZeynelKoca wants to merge 1 commit into
ZeynelKoca wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: b431e9e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Author
|
@dhable Any indication on when this can be merged + released? Running into production upgrade issues now, which we had to find a temporary solution for. |
Author
|
Relevant PR for single-replica upgrade issues: ClickHouse/clickhouse-operator#208 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
clickstack-operatorschart at v1.0.0 declares itsclickhouse-operator-helmdependency as~0.0.2. In Helm's Masterminds semver implementation, the tilde range for pre-1.0 patch-level versions is interpreted narrowly as>=0.0.2 <0.0.3— so this dep resolves only to v0.0.2 of the operator chart, even though newer 0.0.x releases (v0.0.3, v0.0.4, v0.0.5) exist.Consumers of
clickstack-operatorsv1.0.0 are effectively pinned to operator v0.0.2 and miss every fix since then. In particular, v0.0.5 ships:spec.podDisruptionBudgeton bothClickHouseClusterandKeeperCluster(lets users override the auto-generated PDB).ClickHouseClusterwithreplicas <= 1:maxUnavailable=1(instead ofminAvailable=1) so single-replica clusters do not deadlock on voluntary disruption (e.g. node drains, upgrades).Jobsinformer the v0.0.5 controller manager requires).We hit this in production: a single-replica deployment of ClickStack on AKS got stuck on a node-pool VM resize because the v0.0.2 operator generated PDBs that no eviction could satisfy (
minAvailable=1on a 1-replica ClickHouse,maxUnavailable=0on a 1-replica Keeper). Bumping the wrapper chart's operator image alone is not enough — the v0.0.5 binary crashloops against v0.0.2's RBAC/CRDs.Fix
Widen the dependency constraint so the chart pulls v0.0.5 (and stays compatible with future 0.0.x releases):
This pulls operator v0.0.5 + its matching CRDs + matching RBAC together, as one consistent set.
Verification
Resolves cleanly, no template errors, all expected resources render.
Changeset
Added
.changeset/bump-clickhouse-operator-helm.md(minor bump) describing the user-visible change for the next release.Notes for adopters
Existing installations have CRDs with
helm.sh/resource-policy: keep(from the original install), which prevents Helm from updating them on upgrade. After this change merges and a new chart release is published, adopters upgrading from v1.0.0 will need a one-timekubectl apply -fof the new CRDs (or remove the keep annotation) to pick up the new schema. This is unrelated to this PR but worth mentioning in the release notes.