Update XSeries for newer Paper versions#129
Open
RobertoVillegas wants to merge 2 commits into
Open
Conversation
Closed
riku6460
suggested changes
Jun 22, 2026
|
|
||
| // LAVA | ||
| LAVA("stationary lava blocks", XMaterial.supports(13) ? Material.LAVA : Material.getMaterial("STATIONARY_LAVA")), | ||
| LAVA("stationary lava blocks", XMaterial.supports(13, 0) ? Material.LAVA : Material.getMaterial("STATIONARY_LAVA")), |
There was a problem hiding this comment.
Minecraft 13.0 does not exist. Also, XMaterial.supports is an internal API.
Comment on lines
+128
to
+131
| <repository> | ||
| <id>jitpack.io</id> | ||
| <url>https://jitpack.io</url> | ||
| </repository> |
There was a problem hiding this comment.
This is not necessary. XSeries is available on Maven Central.
https://central.sonatype.com/artifact/com.github.cryptomorin/XSeries
…en Central - Replace internal XMaterial.supports(major, minor) with the public XReflection.supports(int) API. The previous supports(13, 0) was wrong since it meant Minecraft 13.0; supports(13) correctly checks for 1.13+. - Drop XSeries to 13.7.0 (latest published on Maven Central) and remove the jitpack.io repository, since XSeries is available on Central.
Author
|
Thanks for the review @riku6460 — both points addressed in the latest commit:
Built cleanly resolving XSeries from Maven Central only. |
|
note: 13.7.0 and 13.8.0 are identical. Only 13.7.0 appears to be available on Maven Central. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing