Polish Marketplace skeleton placeholders#330
Merged
Merged
Conversation
- Replace custom MarketplaceCardSkeleton with ApiCardSkeleton from ApiCard.tsx to achieve exact shape parity (same layout, stats section, and dimensions) - Fix broken JSX in ApiCard.tsx (missing closing div around sparkline row) - Fix missing Fragment import in Skeleton.tsx - Expand skeleton test suite from 1 to 3 focused tests covering card structure, header, sidebar, and toolbar parity Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #288
Summary
MarketplaceCardSkeletonshape with the realApiCardSkeletonfor full skeleton-to-card parityTest plan
npx vitest run src/pages/MarketplacePage.skeleton.test.tsx— 4 tests passingApiCardSkeletonstructure inApiCard.tsx🤖 Generated with Claude Code