Task/conservation ladder#597
Open
ola196 wants to merge 3 commits into
Open
Conversation
- Extract DEFAULT_MAX_DEDUCT constant and check_max_deduct() helper into
contracts/vault/src/limits.rs for clear separation of cap logic
- Re-export from lib.rs (pub mod limits; pub use limits::{...})
- Replace inline if-checks in deduct() and batch_deduct() with check_max_deduct()
- Add focused unit tests in test_limits.rs (7 tests: default value, at/below/above
cap, edge cases)
- Update docs/interfaces/vault.json: improve get_max_deduct description, add
missing set_max_deduct entry with params, errors, and event docs
Closes CalloraOrg#538
Add tests/conservation_ladder.rs: 64-seed × 48-step property test asserting that total on-ledger USDC across vault, settlement, and revenue-pool plus all wallet balances equals INITIAL_MINT after every operation (deposit, deduct, batch_deduct, developer withdraw, revenue-pool batch_distribute). Also checks settlement's internal conservation invariant: usdc.balance(settlement) >= global_pool.total_balance + Σ dev_balances Uses a deterministic LCG PRNG (no external crates) for reproducibility; any violation prints the seed and full step trace.
|
Hey @ola196! 👋 It looks like this PR isn't linked to any issue. If this PR is for one of the issues assigned to you as part of a Wave, please link it to ensure your contribution is tracked properly. You can do this by adding a keyword to the PR description (e.g.,
|
- vault: add TotalDeducted storage key + get_total_deducted() view - settlement: add TotalReceived storage key + get_total_received() view - test_cross_invariant: 64-seed x 48-step end-to-end conservation check - docs: update vault.json and settlement.json interface summaries Closes CalloraOrg#539
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.