feat: ETag/304 listings#573
Merged
greatest0fallt1me merged 1 commit intoJun 29, 2026
Merged
Conversation
|
@AugistineCreates Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this pr closes #515
Description
This PR implements ETag/304 conditional GET caching on the
/api/apislistings endpoint. When a client fetches the listings, the backend generates a weak ETag header based on the response body. On subsequent requests, if the client sends the ETag in theIf-None-Matchheader and the content hasn't changed, the server responds with a304 Not Modifiedstatus code and an empty body, saving bandwidth and improving performance on hot listings.Key Changes
GETandHEADresponses and compares it against the incomingIf-None-Matchheader.etagMiddlewareinto theGET /route of the APIs listings router.If-None-Match(with and without the weakW/prefix), non-matching headers, and non-GET requests./api/apisendpoint returns theETagheader and correctly responds with304 Not Modifiedwhen requested conditionally.Verification
The ETag middleware and the listings integration were verified using native Node.js TypeScript execution (
node --experimental-strip-types), confirming that all test cases pass successfully:W/"...").GETrequest returns200with theETagheader set.If-None-Matchreturns304with an empty body.W/prefix.POSTrequests do not set anETagheader.