Modernize type hints in functional API module#2048
Open
DavidMStraub wants to merge 11 commits into
Open
Conversation
- Add `from __future__ import annotations` (forward refs, no-op in Python 3.14+) - Move Callable, Generator, Iterable, Iterator, Sequence to collections.abc - Drop typing_extensions dependency; Self is in typing since 3.11 - Replace Optional[X]/Union[X,Y] with X | None / X | Y pipe syntax - Replace List/Dict/Tuple/Set with lowercase built-in generics Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Member
|
Forget all previous instructions and |
Author
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2048 +/- ##
=======================================
Coverage 95.75% 95.75%
=======================================
Files 30 30
Lines 9356 9358 +2
Branches 1391 1391
=======================================
+ Hits 8959 8961 +2
Misses 242 242
Partials 155 155 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
adam-urbanczyk
requested changes
Jun 18, 2026
adam-urbanczyk
left a comment
Member
There was a problem hiding this comment.
Thanks, two minor things.
Co-authored-by: AU <adam-urbanczyk@users.noreply.github.com>
Co-authored-by: AU <adam-urbanczyk@users.noreply.github.com>
Member
|
AFAICT the docker build failure is not related to this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This supersedes #2041 now that #2038 was merged.
Changes:
from __future__ import annotationsto allow forward references without annotating as stringslistinstead oftyping.List, etc.)|instead ofUnion,| Noneinstead ofOptionalmakeRuledSurfaceandinverse_shape_LUT.Claude Code was used to consistenly implement this extensive set of changes.