feat: add 10s countdown before running custom extension scripts#219
Open
AnAverageBeing wants to merge 1 commit into
Open
feat: add 10s countdown before running custom extension scripts#219AnAverageBeing wants to merge 1 commit into
AnAverageBeing wants to merge 1 commit into
Conversation
extensions that ship a custom install, update or removal script now show a 10 second countdown before the script runs. press enter to continue immediately or ctrl+c to cancel. non-interactive sessions skip the wait automatically.
AnAverageBeing
force-pushed
the
feat/custom-script-confirm
branch
from
c3c7b19 to
bcf3805
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when an extension ships a custom install, update or removal script, blueprint prints a caution warning and immediately runs it. theres no pause, so if you see the warning and want to check whats in the script before it runs, youre already too late.
this adds a 10 second countdown prompt before any of those scripts execute. you can hit enter to go immediately or ctrl+c to bail out clean. non-interactive environments (pipes, ci) skip the wait automatically, and theres a
BLUEPRINT_SKIP_SCRIPT_CONFIRMenv var if you want to disable it manually.files changed
scripts/libraries/misc.sh- addedblueprint_custom_script_confirm(), sourced globally viablueprint.shscripts/commands/extensions/install.sh- update path + install pathscripts/commands/extensions/remove.sh- removal path