fix(music): default to music-3.0 and list current models - #227
Open
octo-patch wants to merge 1 commit into
Open
Conversation
The MiniMax music generation provider still defaulted to music-2.5+ and advertised only the legacy music-2.5 variants. Refresh the provider registration and the audio generation proxy default to the current music-3.0 model and advertise the current generation model list (music-3.0, music-2.6, music-3.0-free, music-2.6-free). Update the e2e mock and live music fixtures to the current model.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughChangesMusic model update
Estimated code review effort: 1 (Trivial) | ~5 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason: refresh the MiniMax music provider to the current music-3.0 model and model list.
The runtime MiniMax music generation provider still defaulted to
minimax/music-2.5+and advertised only the legacymusic-2.5variants. This refreshes the registered default and model list to the current generation models.Changes:
src/index.ts(buildMusicGenerationProvider): default model is nowminimax/music-3.0and the advertisedmodelslist now includesminimax/music-3.0,minimax/music-2.6,minimax/music-3.0-free, andminimax/music-2.6-free.src/proxy.ts(/v1/audio/generationshandler): the fallbackaudioModeldefault is nowminimax/music-3.0.test/test-e2e.ts: updated the mock upstream response and the local/live music fixtures to useminimax/music-3.0.Checks run:
npx tsc --noEmit— passed.npx vitest run— 723 passed / 3 skipped (one flaky lifecycle timeout passed on re-run; unrelated to this change).npx tsx test/test-e2e.ts— 20 passed / 0 failed (mocked audio generation path exercised with the refreshed model).Summary by CodeRabbit
New Features
minimax/music-3.0.minimax/music-3.0,minimax/music-2.6, and their free variants.Bug Fixes
Tests