Skip to content

docs(web-demo): add consumer config matrix for retail and UI#9235

Open
mmcshinsky-bitgo wants to merge 3 commits into
masterfrom
side/web-demo-profile-readme
Open

docs(web-demo): add consumer config matrix for retail and UI#9235
mmcshinsky-bitgo wants to merge 3 commits into
masterfrom
side/web-demo-profile-readme

Conversation

@mmcshinsky-bitgo

@mmcshinsky-bitgo mmcshinsky-bitgo commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Expand `modules/web-demo/README.md` with a consumer config matrix mapping planned `CONSUMER_PROFILE` setups to bitgo-retail and bitgo-ui bundling patterns
  • Document current demo routes and which production problems each route illustrates
  • Extend `commitlint.config.js` with `WEB-` as an issue prefix for side-branch work
  • Update `.github/workflows/ci.yml` to run a new `code-quality (scripts)` check against `scripts/tests/`
  • Add `CLAUDE.md` note on the junk-drawer `WEB-000` reference pattern
  • Refactor `scripts/prepare-commit-msg.js`: extract pure `extractTicket` / `appendTicketFooter` functions; bail when `issuePrefixes` is empty to avoid matching bare-digit branches; fix `commitRegex.lastIndex` leakage across repeated `.test()` calls
  • Add `scripts/tests/prepare-commit-msg.test.js` with 12 unit tests covering extraction, footer append, dedup, and regex-safety edge cases

Test plan

  • `yarn run test:scripts` — 12 passing
  • Commitlint passes on all commits in range
  • Review matrix accuracy for retail WASM aliases and auth flows (manual verify before merge)

No ticket — local side improvement.

@mmcshinsky-bitgo mmcshinsky-bitgo requested review from a team as code owners July 10, 2026 22:24
@mmcshinsky-bitgo mmcshinsky-bitgo marked this pull request as draft July 10, 2026 22:25
mmcshinsky-bitgo added a commit that referenced this pull request Jul 10, 2026
Document planned CONSUMER_PROFILE setups and map demo routes to
production patterns from bitgo-retail and bitgo-ui.

#9235
@mmcshinsky-bitgo mmcshinsky-bitgo force-pushed the side/web-demo-profile-readme branch from 601f36d to 50642ee Compare July 10, 2026 22:27
Add WEB- to commitlint parser prefixes and normalize ticket IDs from
junk-drawer WEB branch names in prepare-commit-msg.

WEB-000
@mmcshinsky-bitgo mmcshinsky-bitgo force-pushed the side/web-demo-profile-readme branch 2 times, most recently from 8073721 to b01cc28 Compare July 10, 2026 22:58
Document planned CONSUMER_PROFILE setups and map demo routes to
production patterns from bitgo-retail and bitgo-ui.

WEB-000
@mmcshinsky-bitgo mmcshinsky-bitgo force-pushed the side/web-demo-profile-readme branch from b01cc28 to 6c602b7 Compare July 10, 2026 23:23

// ex WP-1234
const branchRegex = /([A-Z]+-)(\d+)/;
// Build regex from commitlint's known issuePrefixes so arbitrary branch segments

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ironically, a script that deserves tests!

Address review feedback: extract a pure appendTicketFooter() from main()
so the footer-writing logic is unit-testable, and add tests for footer
append, existing-footer dedup (TICKET/ISSUE, any case), null-ticket
skip, branch-start anchoring, and global-regex lastIndex safety.

TICKET: WEB-000
@mmcshinsky-bitgo mmcshinsky-bitgo self-assigned this Jul 13, 2026
@mmcshinsky-bitgo mmcshinsky-bitgo marked this pull request as ready for review July 13, 2026 15:49
@mmcshinsky-bitgo mmcshinsky-bitgo requested a review from a team as a code owner July 13, 2026 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants