fix(root): add npm overrides mirroring yarn resolutions#9212
Open
mihir-bitgo wants to merge 1 commit into
Open
fix(root): add npm overrides mirroring yarn resolutions#9212mihir-bitgo wants to merge 1 commit into
mihir-bitgo wants to merge 1 commit into
Conversation
npm consumers of `bitgo` ignore yarn's `resolutions` block, so `npm audit` surfaces vulnerabilities our yarn-based CI already patches. Add an `overrides` block translating all 70 pinned packages so `npm install` resolves the same safe versions when bitgo is the root of the install. TICKET: WCN-604
Contributor
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bitgodon't get yarn'sresolutionspins, sonpm auditsurfaces vulnerabilities our yarn-based CI already patchesoverridesblock to rootpackage.jsontranslating all 70 pinned packages sonpm installresolves the same safe versions when bitgo is the root of the installoverridesonly takes effect when the installed package is the root of the install — it does not help whenbitgois installed as a dependency of a customer app (that's covered separately in a follow-up PR shippingnpm-shrinkwrap.json)Test plan
package.jsonparses as valid JSONnpm install --package-lock-onlyin an isolated copy resolves the pinned versionsyarn installstill succeeds unaffected (yarn ignoresoverrides)TICKET: WCN-604
🤖 Generated with Claude Code