feat: include enterpriseId as AAD in passkeys encryption process#9210
Merged
Conversation
Contributor
OttoAllmendinger
previously approved these changes
Jul 9, 2026
OttoAllmendinger
requested changes
Jul 9, 2026
OttoAllmendinger
left a comment
Contributor
There was a problem hiding this comment.
please add a test that shows that adata: undefined and omitted adata are equivalent
vibhavgo
reviewed
Jul 9, 2026
vibhavgo
left a comment
Contributor
There was a problem hiding this comment.
Shouldn't we also add a test to ensure that a key encrypted in one enterprise context shouldn't be able to be decrypted in another enterprise context?
OttoAllmendinger
approved these changes
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding
enterpriseIdas AES-GCM AAD to PRF-encrypted private keysNote: what if no enterprise?
attachPasskeyToWallet: safe, already throws before reaching encrypt if enterprise is missingand
wallets.tswallet creation:params.enterpriseisenterprise?: string (optional). undefined is handledwallets.tsbulk share accept:walletShare.enterpriseis also optional. undefined is handledso enterprise membership should already be enforced by the server first.
Ticket: WCN-1074