AP-687 Only download files if local file is older#13
Merged
Conversation
Contributor
jason-raitz
commented
May 22, 2026
jason-raitz
commented
- given a UTC modified datetime string for the requested file, we now check if the file exists locally and has a newer mtime
jason-raitz
requested review from
anarchivist,
awilfox,
danschmidt5189 and
yzhoubk
awilfox
reviewed
May 22, 2026
Member
awilfox
left a comment
awilfox
left a comment
There was a problem hiding this comment.
r+wc; minor documentation fixes.
Member
|
It would be nice to have a test. We should be able to mock |
Co-authored-by: Anna Wilcox <AWilcox@Wilcox-Tech.com>
Co-authored-by: Anna Wilcox <AWilcox@Wilcox-Tech.com>
Member
|
I'm thinking about this and… Should we pass in a |
anarchivist
approved these changes
May 27, 2026
| return records[0] | ||
|
|
||
| def fetch_file(self, file_url: str, output_dir: str = "") -> str: | ||
| def fetch_file(self, file_url: str, output_dir: str = "", modified: str = "") -> str: |
Member
There was a problem hiding this comment.
following @awilfox's suggestion, i think modified should actually be a datetime.datetime - it shouldn't be this method's responsibility to convert the incoming string into a value that can be compared.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.