Skip to content

Record @typespec/http-client-python version in generated metadata#47427

Merged
msyyc merged 2 commits into
mainfrom
record-http-client-python-version
Jun 10, 2026
Merged

Record @typespec/http-client-python version in generated metadata#47427
msyyc merged 2 commits into
mainfrom
record-http-client-python-version

Conversation

@msyyc

@msyyc msyyc commented Jun 10, 2026

Copy link
Copy Markdown
Member

Description

In addition to emitterVersion (@azure-tools/typespec-python), this change also records the @typespec/http-client-python version from eng/emitter-package.json in the generated npm package version metadata.

The version is read from devDependencies in eng/emitter-package.json and only added when present, so behavior is unchanged when the dependency is absent.

@msyyc msyyc marked this pull request as ready for review June 10, 2026 08:18
@msyyc msyyc requested a review from scbedd as a code owner June 10, 2026 08:18
Copilot AI review requested due to automatic review settings June 10, 2026 08:18
@msyyc msyyc requested a review from danieljurek as a code owner June 10, 2026 08:18

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request updates the TypeSpec SDK generation metadata to additionally capture the @typespec/http-client-python version from eng/emitter-package.json (when present), alongside the existing emitterVersion (@azure-tools/typespec-python).

Changes:

  • Read @typespec/http-client-python from devDependencies in eng/emitter-package.json.
  • Conditionally add that version into the generated metadata dictionary when the dependency exists.

Comment thread eng/tools/azure-sdk-tools/packaging_tools/generate_utils.py Outdated
Comment thread eng/tools/azure-sdk-tools/packaging_tools/generate_utils.py Outdated
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@msyyc msyyc enabled auto-merge (squash) June 10, 2026 08:28
@msyyc msyyc disabled auto-merge June 10, 2026 08:58
@msyyc msyyc merged commit 5a68380 into main Jun 10, 2026
18 checks passed
@msyyc msyyc deleted the record-http-client-python-version branch June 10, 2026 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants