ci(azure-sdk-tools): declare contents: read#46863
Open
arpitjain099 wants to merge 1 commit into
Open
Conversation
github-actions
Bot
added
Community Contribution
Contributor
|
Thank you for your contribution @arpitjain099! We will review the pull request and get back to you soon. |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an explicit minimal-permissions configuration to the azure-sdk-tools GitHub Actions workflow to align with the repository’s established pattern of declaring top-level permissions.
Changes:
- Declares top-level
permissions: contents: readin.github/workflows/azure-sdk-tools.ymlto ensure the workflow token is scoped to read-only repository contents.
arpitjain099
force-pushed
the
ci/add-permissions
branch
from
f3ca77c to
c2c26ab
Compare
Author
|
Hi @howieleung, gentle ping on this. PR has been open for 4 days without review. I noticed you've been on the recent-merger side of recent merges in this repo. When you have a moment, would you mind giving it a quick look? No urgency. Happy to address any feedback. |
Author
|
Hey, Coming back around on this - any chance of a look when you have a moment? Happy to address feedback. Appreciated. |
mikeharder
approved these changes
May 26, 2026
This is the one remaining workflow in this repo without an explicit top-level permissions block. The job only checks out, runs pytest, black, and azpysdk discovery against the eng/tools/azure-sdk-tools package - no GitHub API surface. contents: read keeps it consistent with the rest of .github/workflows in this repo. Signed-off-by: Arpit Jain <arpitjain099@gmail.com>
arpitjain099
force-pushed
the
ci/add-permissions
branch
from
3bb5805 to
322a13e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every other workflow in
.github/workflows/here already declares a top-level permissions block.azure-sdk-tools.ymlis the one outlier.The job only checks out the tree and runs pytest, black, and an azpysdk command-discovery script against
eng/tools/azure-sdk-tools. No GitHub API writes. Addingpermissions: contents: readaligns it with the existing pattern (seeevent.ymlusingpermissions: {},post-apiview.ymlusingcontents: read + pull-requests: write, etc.).YAML re-parsed locally. No behavior change.