Agentic UI: Rework the new-user onboarding screens - #4413
Open
bcotrim wants to merge 4 commits into
Open
Conversation
Contributor
TIL: this is nice and makes testing so much easier 👍 |
Collaborator
📊 Performance Test ResultsComparing 1ba27d5 vs trunk app-size
site-editor
site-startup
Results are median values from multiple test runs. Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change (<50ms diff) |
| viewBox="0 0 200 130" | ||
| fill="none" | ||
| xmlns="http://www.w3.org/2000/svg" | ||
| aria-hidden="true" |
Contributor
There was a problem hiding this comment.
I see that in some places we specifically set it to true while in others just pass true as default. I am wondering if we should stick to one approach? It is not a big deal though, mostly a nit
| } | ||
| /> | ||
| <p className={ styles.legal }> | ||
| { __( 'By continuing, you agree to our' ) }{ ' ' } |
Contributor
There was a problem hiding this comment.
Should we use createInterpolateElement with a single translatable string containing placeholder markers here to avoid splitting the sentence in 4 different bits?
| ], | ||
| }, | ||
| { | ||
| title: __( 'Build with Studio Code' ), |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Related issues
How AI was used in this PR
Claude ported the design from the exploration branch (
explore-site-centric-conversation-chrome, #3975) onto current trunk, and I reviewed every screen in the running app. Worth a close look at two things the AI changed rather than copied:welcomeStylesinto connect and tour for the feature card and auth buttons. That's extracted into shared components instead — which surfaced real drift, e.g. the tour usedvariant="outline"for Log in while welcome usedsolid, under a comment claiming they matched.EmptyBackgroundis parameterized on top of trunk's version rather than taking the exploration's copy, since f61ebe7 changed that component after the branch forked.Proposed Changes
Second pass on the first-run flow: welcome → concept tour → Add a site. Each screen now owns one story instead of three screens repeating the same pitch.
Testing Instructions
The welcome only shows with zero sites, so point the app at an empty config rather than deleting yours:
Pre-merge Checklist