fix(playlist): show image icon placeholder in Create Playlist artwork#14425
Merged
Conversation
The Create Playlist modal's artwork picker rendered a gray box with a blank PNG placeholder over it, which read as a perpetual loading skeleton even though no artwork has ever been associated yet. Add an optional `iconPlaceholder` prop to `UploadArtwork` and pass `IconImage` from `CreatePlaylistModal` so the empty state shows a clear "add artwork" affordance. Scoped to create — the edit flow (where artwork may still be loading) is unchanged. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Contributor
🌐 Web preview readyPreview URL: https://audius-web-preview-pr-14425.audius.workers.dev Unique preview for this PR (deployed from this branch). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Create Playlist modal's artwork picker rendered a gray box with a blank PNG placeholder, which read like a perpetual loading skeleton even though no artwork has ever been associated yet (the modal is for creating a brand new playlist).
Fix scoped to the create flow only:
Edit flows that use `UploadArtwork` via `ArtworkField` (`EditCollectionForm`, track edit, etc.) don't pass the new prop and keep their existing behavior — artwork-while-loading still shows the existing placeholder.
Test plan
🤖 Generated with Claude Code