Skip to content

Newapi#18

Open
yuxingfengs wants to merge 26 commits into
mainfrom
newapi
Open

Newapi#18
yuxingfengs wants to merge 26 commits into
mainfrom
newapi

Conversation

@yuxingfengs

Copy link
Copy Markdown
Collaborator

add function in vue and add illustration in read me

Comment thread README.md
- Network Name: ETH
- New RPC URL: http://127.0.0.1:8545
- Chain ID: 1337
3. Import an account from Ganache into MetaMask.

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Points one through three are a little unspecific. I'm not sure what to do here. We can discuss this further in the meeting

Comment thread README.md
In the terminal of the Visual Studio Code console, follow these steps:

1. Install Vue CLI globally: `npm install -g @vue/cli`
2. Install web3: `npm install web3`

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Packages that are not installed globally should be installed through npm install via the packages.json file

Edit: web3 and big-integer are already covered in the packages.json, so instructions 2. and 3. are unnecessary, and instruction 1. is already in the Prerequisites section.

Comment thread README.md
- Run ``npm run serve`` and open the displayed URL in your browser


## Project Setup

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section's instructions are already covered in the Backend section

Comment thread README.md
- Chain ID: 1337
3. Import an account from Ganache into MetaMask.

## Start Vue

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section is also already covered. We could add the npm run build command to the front end, though.

if (typeof window.ethereum !== 'undefined') {
this.web3 = new Web3(window.ethereum);

// 等待用户登录和选择账户

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please keep comments in english

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants