Skip to content

Fix PLT-1 temperature thresholds pinned to °C#18

Open
bharvey88 wants to merge 1 commit into
mainfrom
fix/plt-1-unit-agnostic-temps
Open

Fix PLT-1 temperature thresholds pinned to °C#18
bharvey88 wants to merge 1 commit into
mainfrom
fix/plt-1-unit-agnostic-temps

Conversation

@bharvey88

@bharvey88 bharvey88 commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

The four soil/air temperature inputs are labeled °C with a -10..50 range. HA converts temperature sensor states to the user's unit system, so on a °F install the state is Fahrenheit but the threshold is Celsius: "below 10" is -12 °C (cold alerts never fire) and "above 30" matches normal room readings (heat alerts fire on every repeat check once enabled).

This drops the °C pin the same way AIR-1's min/max temperature inputs handle it:

  • Names lose the "(°C)" suffix, selectors lose unit_of_measurement
  • Range widened to -20..130 so both scales fit
  • Each description says to use the unit the sensor shows in HA, with dual-unit starting points (e.g. 10 °C / 50 °F)

Defaults are unchanged. Existing automations keep their stored values.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Improvements
    • Updated soil and air temperature alert settings to use clearer, unit-aware labels and guidance.
    • Expanded allowed temperature ranges for both minimum and maximum values, supporting a wider set of sensor readings.
    • Removed fixed temperature units so the app can follow the sensor’s displayed unit automatically.

The four soil/air temperature inputs were pinned to Celsius (°C label,
-10..50 range). Home Assistant converts temperature sensor states to
the user's unit system, so on a Fahrenheit install the °F state is
compared against a °C threshold: 'below 10' is -12 °C, so cold alerts
never fire, and 'above 30' matches normal room readings, so heat
alerts fire on every check. Drop the unit pin, widen the range to
cover both scales, and give dual-unit starting points in each
description.

🤖 Generated with [Claude Code](https://claude.com/claude-code)
@coderabbitai

coderabbitai Bot commented Jul 2, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: f1477fc3-a9fa-46f3-b325-3c27ab1869f6

📥 Commits

Reviewing files that changed from the base of the PR and between f84c28e and 847314d.

📒 Files selected for processing (1)
  • PLT-1/PLT-1.yaml

Walkthrough

This PR updates the Soil Temperature and Air Temperature alert threshold inputs in the blueprint YAML file. Field labels are made unit-agnostic, descriptions are expanded with °C/°F guidance, the numeric slider range is widened from -10–50 to -20–130, and fixed unit_of_measurement values are removed.

Changes

Temperature threshold input updates

Layer / File(s) Summary
Soil and Air Temperature threshold inputs
PLT-1/PLT-1.yaml
Min/max fields for Soil and Air Temperature are retitled, given unit-agnostic descriptions with °C/°F examples, numeric range expanded (-10–50 → -20–130), and fixed unit_of_measurement removed from selectors.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Poem

A rabbit hopped through YAML fields so wide,
Stripping fixed degrees, letting units glide,
From -20 to 130, thresholds now stretch,
Celsius or Fahrenheit, both within fetch,
Hop hop hooray for flexible degrees! 🐇🌡️

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main fix: removing Celsius-only temperature thresholds in PLT-1.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/plt-1-unit-agnostic-temps

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant