Skip to content

custom data accessor#418

Closed
jdeniau wants to merge 4 commits into
AllenFang:masterfrom
jdeniau:customDataAccessor
Closed

custom data accessor#418
jdeniau wants to merge 4 commits into
AllenFang:masterfrom
jdeniau:customDataAccessor

Conversation

@jdeniau

@jdeniau jdeniau commented Apr 26, 2016

Copy link
Copy Markdown

I created a custom data accessor. The purpose is the same as #50 but it provide a more flexible way of doing it.

You only need to pass a dataAccess parameter to the TableHeaderColumn. The function takes the data as parameter and you can return whatever you want.

This way, it fixes nested properties, but also if you use something like immutablejs it works fine.

I kept the dataField attribute as I saw you use it for a lot of purpose, but as it is not used for accessing data, it's more like an id I think.

I make it work with simple filter, it does not work with search because you iterate over each object instead of each column here.

Fixes #50

@jdeniau

jdeniau commented Apr 26, 2016

Copy link
Copy Markdown
Author

The tests are failing on an npm error I think between react-toastr which now requires react >= 15 and your component and / or react-dom

@AllenFang

Copy link
Copy Markdown
Owner

@jdeniau, thanks your contribution :) I'll check this out in these day

jfremy added a commit to jfremy/react-bootstrap-table that referenced this pull request Jun 15, 2016
rebased the code on latest master
added support for search
updated example to show filtering and search
@welcoMattic

Copy link
Copy Markdown

Is someone still working on this PR? Fixing conflicts?

@jdeniau

jdeniau commented Sep 17, 2016

Copy link
Copy Markdown
Author

I'm not, I do not use this package anymore but feel free to update it

Le 16 sept. 2016 15:15, "Mathieu Santo Stefano--Féron" <
notifications@github.com> a écrit :

Is someone still working on this PR? Fixing conflicts?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#418 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABVWxf1LGAdXOh1-cBHC5uIIdI964jbBks5qqpaGgaJpZM4IQNN_
.

@welcoMattic

Copy link
Copy Markdown

@AllenFang I think you can closes this PR since this one (#508) is open.

@jdeniau

jdeniau commented Jul 13, 2017

Copy link
Copy Markdown
Author

Closing in favor of #508

@jdeniau jdeniau closed this Jul 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

dataField can't access subobject

3 participants