dpl-workflow: Add missing flags to disable ctp-lumi-request#15446
Merged
Conversation
shahor02
reviewed
May 29, 2026
| TOF_INPUT=digits | ||
| GPU_INPUT=zsonthefly | ||
| has_detector TPC && add_W o2-tpc-reco-workflow "--input-type digits --output-type zsraw,disable-writer $DISABLE_MC --pipeline $(get_N tpc-zsEncoder TPC RAW 1 TPCRAWDEC)" | ||
| has_detector TPC && add_W o2-tpc-reco-workflow "--input-type digits --output-type zsraw,disable-writer $DISABLE_MC $([[ $TPC_CORR_OPT == *--disable-ctp-lumi-request* ]] && echo --disable-ctp-lumi-request) --pipeline $(get_N tpc-zsEncoder TPC RAW 1 TPCRAWDEC)" |
Collaborator
There was a problem hiding this comment.
@davidrohr @fweig Does o2-tpc-reco-workflow ever need the tpc-scaler workflow if the output-type is not tracks. And the same for the CTPLumi (used only to scale TPC tracks syst errors).
In opposite, for the same reason, if in the o2-gpu-reco the we add --disable-ctp-lumi-request (e.g. because the scaling is done with IDC), how the TPC syst errors scaling will be done? https://github.com/fweig/AliceO2/blob/cba61dce62a1a213e20e68581ffc5c0adf225825/prodtests/full-system-test/dpl-workflow.sh#L615
Collaborator
There was a problem hiding this comment.
@shahor02 : if i inderstand correctly, this fix was suggested by @matthias-kleiner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.