Skip to content

fix(chat): prevent overlap while virtual rows grow live#425

Merged
khaliqgant merged 1 commit into
mainfrom
fix/codex-424-chatview-overlap
Jul 19, 2026
Merged

fix(chat): prevent overlap while virtual rows grow live#425
khaliqgant merged 1 commit into
mainfrom
fix/codex-424-chatview-overlap

Conversation

@khaliqgant

@khaliqgant khaliqgant commented Jul 19, 2026

Copy link
Copy Markdown
Member

Summary

  • synchronously resize only the mounted chat row whose layout-affecting message props changed
  • retain ResizeObserver measurement for initial size, viewport, font, and width changes
  • add geometry regressions for an initially large agent_relay.post_message result and a live-growing result

Root cause

The tool-call payload renderer is ordinary block-flow markup, so overflow-visible and the fixed estimate are not the source of the persistent overlap. Initial large rows are measured correctly. The failure occurs when an already-mounted message grows: until the asynchronous ResizeObserver delivery updates the cached row size, the next absolute row keeps its old translateY and can paint over the newly taller content. The changed row now reports its committed offsetHeight to react-virtual from a layout effect, moving successor rows before paint.

Evidence

Before the fix, the live-growth regression rendered the first row at 788px while the second row remained at translateY(88px). The initial-large-payload case already passed, which ruled out content escaping normal flow. Both cases pass after the targeted synchronous resize.

Test plan

  • npx vitest run src/renderer/src/components/chat/ChatView.dom.test.ts
  • npm run test:all (129 Node tests and 607 Vitest tests)
  • npm run typecheck
  • npm run lint

Closes #424

Review in cubic

@khaliqgant khaliqgant added the no-agent-relay-review Disable agent-relay automated PR review/fixes label Jul 19, 2026
@gemini-code-assist

Copy link
Copy Markdown

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@coderabbitai

coderabbitai Bot commented Jul 19, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@khaliqgant, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 28 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: bcdcd572-4c63-4478-ba08-3f061462c9fd

📥 Commits

Reviewing files that changed from the base of the PR and between b52004a and f81c01f.

📒 Files selected for processing (2)
  • src/renderer/src/components/chat/ChatView.dom.test.ts
  • src/renderer/src/components/chat/ChatView.tsx
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/codex-424-chatview-overlap

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@khaliqgant
khaliqgant marked this pull request as ready for review July 19, 2026 05:40
@gemini-code-assist

Copy link
Copy Markdown

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@cursor

cursor Bot commented Jul 19, 2026

Copy link
Copy Markdown

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

@khaliqgant
khaliqgant merged commit 5617b19 into main Jul 19, 2026
5 checks passed
@khaliqgant
khaliqgant deleted the fix/codex-424-chatview-overlap branch July 19, 2026 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-agent-relay-review Disable agent-relay automated PR review/fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Chat message list: overlapping/duplicated text under large tool-call blocks (react-virtual measurement)

1 participant