fix: verify broker name release before reuse

[kjgbot]

Summary

• verify the raw Harness Driver inventory after every successful broker release
• retry the public release when a stale name remains instead of immediately colliding on resume
• fail closed after bounded retries and cover the live success-but-row-retained regression

Live evidence

Factory 0.1.46 on the patched broker discovered 106 ready candidates and released all durable leases on shutdown. During startup recovery, a release acknowledgement was followed by a retained dead broker row; a second public Harness Driver release removed it. Relay root cause: intentional worker release did not unregister the restart supervisor, allowing maintenance to resurrect the name.

Verification

• build and feature map pass
• InternalFleetClient: 65/65
• full suite: 1,084/1,084
• exact packed consumer E2E: 9/9 for ffb5ebb672ad386f5656c861ea41eb87f72074ee
• Relay broker suite: 794 passed, 4 ignored, plus 16 integration tests

[coderabbitai]

Warning

Review limit reached

@kjgbot, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 51 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: b1b480c8-75d5-49b3-b44b-365bae85f576

📥 Commits

Reviewing files that changed from the base of the PR and between b406c35 and c273765.

📒 Files selected for processing (5)

• .github/workflows/ci.yml
• scripts/verify-packed-e2e.mjs
• src/fleet/internal-fleet-client.test.ts
• src/fleet/internal-fleet-client.ts
• src/packed-e2e-attestation.test.ts

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/verify-local-agent-release

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[gemini-code-assist]

Code Review

This pull request updates the InternalFleetClient to retry releasing a broker until its name is no longer returned by listAgents(), preventing issues where a successful release acknowledgement is received but the broker name remains active. Feedback suggests adding defensive checks to ensure listAgents() returns a valid array and using optional chaining when checking agent names to prevent potential runtime type errors.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.