basic-workflow: Update to Versioned Repos, phase2#113
Conversation
This changes the moss repository and boulder profile CLI input format and output format slightly, just as their respective config formats are changed from YAML to KDL. Signed-off-by: Rune Morling <ermo@aerynos.com>
|
I'd say aside from the consistency comment from @hphilm all looks good! |
NomadicCore
left a comment
There was a problem hiding this comment.
If my system is anything to go by, the output of moss repo list still shows the old format for unstable but the new format for volatile.
I have suggested we add the command for converting over/adding both unstable and volatile repo's with the new command structure. If the user already has it in the new format, it won't make a difference so becomes a catch all.
This also flags for me if/when we should do a new ISO so new users fall into the new kdl format as soon as possible?
| moss repo list | ||
| # output | ||
| - unstable = https://cdn.aerynos.dev/stream/unstable/x86_64/stone.index [0] | ||
| - unstable = (base-uri=https://cdn.aerynos.dev/, channel=main, version=stream/unstable, arch=x86_64) [0] |
There was a problem hiding this comment.
For an existing user (after they have synced to the latest moss and are on the new repo, the unstable repo is still in the old format.
I'm guessing this will be true until we roll out a new iso with the new moss and format already baked in.
It's not hard to change it to the new format with the following command
sudo moss repo add unstable https://cdn.aerynos.dev --root-index channel=main,version=stream/unstable -p 0
I'm guessing this won't make a difference to existing installs as it will figure it out but would it make sense to add that users may see
moss repo list
- unstable = https://cdn.aerynos.dev/stream/unstable/x86_64/stone.index [0]
and therefore guide them on how to update from that too if that is the case?
There was a problem hiding this comment.
As of now it seems to be correct since unstable is currently still a legacy repo. Only will change when there is a new unstable stream update done. I assume local repos will stay at the legacy format ...
There was a problem hiding this comment.
This also flags for me if/when we should do a new ISO so new users fall into the new kdl format as soon as possible?
The goal was to get the ball rolling, because we've been sitting on this change for too long already.
Currently, we may need to do some re-jiggering repo wise, where we manually downgrade the infra to legacy repo format (= pretend that we didn't just upgrade), add the fixed moss that also works for system-model users to the legacy repo for correct user-facing upgrades for system-model users, then re-run the infra upgrade.
It will be interesting to see what this does for users who were already converted. 😬
In any case, as soon as this upgrade has been rectified (current plan is the coming Tuesday), we should then aim to sync, so we get everyone onto the new repository (and config) format.
Co-authored-by: NomadicCore <github.sneeze312@passmail.net>
|
LGTM |
This changes the moss repository and boulder profile CLI input format and output format slightly, just as their respective config formats are changed from YAML to KDL.