feat: iframe-based app onboarding as a temporary integration path#14
Closed
oto-macenauer-absa wants to merge 1 commit into
Closed
feat: iframe-based app onboarding as a temporary integration path#14oto-macenauer-absa wants to merge 1 commit into
oto-macenauer-absa wants to merge 1 commit into
Conversation
Add an iframe onboarding mode so teams can be listed in the marketplace with a single URL, without a headless package/release artifact. Explicit stopgap. - apps.json: new "type": "iframe" + "url" entry type (no repo/marketplace.json/ artifact required); optional "temporary": true to flag entries for migration. - src/utils/apps.js: getAppPages emits a single route per iframe entry. - src/pages/[...path].astro: renders a full-viewport <iframe> inside the marketplace chrome (standalone) or full-height (headless/embedded); packaged apps are unchanged. - src/components/AppCard.astro + marketplace.css: "External" badge on iframe cards in the catalogue. - scripts/build-vite.js: skip iframe entries in artifact/asset steps; validate registry entries (iframe requires url; packaged requires a source); warn on temporary entries; include iframe apps in the summary count. - Tests: register a third (iframe) app in the test registry; build-integrity covers the iframe route, the External badge, no packaged pages, and that packaged apps are unaffected. - Docs: README registry section + HEADLESS_RULES.md note (temporary nature, cross-origin embedding requirement). Closes #10 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #10.
Adds a lightweight iframe onboarding mode so teams can appear in the marketplace with a single URL — no headless package,
marketplace.json, or release artifact. An explicit temporary stopgap.Changes
apps.json): new"type": "iframe"+"url"entry type; optional"temporary": trueto flag for migration.repo/marketplace.json/artifact not required.src/utils/apps.js):getAppPagesemits a single route per iframe entry (no filesystem crawl).src/pages/[...path].astro): renders a full-viewport<iframe>(sandboxed) inside the marketplace chrome when standalone, full-height when headless/embedded. Packaged apps are completely unchanged.AppCard.astro+marketplace.css): an External badge on iframe cards.scripts/build-vite.js): iframe entries skip the fetch/build + asset steps; up-front registry validation (iframe requiresurl; packaged requiresrepo/localPath/prebuilt); warns ontemporaryentries; counts iframe apps in the summary.HEADLESS_RULES.mdnote (temporary nature; the external site must allow embedding — CSPframe-ancestors/X-Frame-Options).Tests
Registers a third iframe app in the test registry;
build-integrity.spec.jsadds aniframe onboardingsuite:<iframe src=…>full-viewportLocal: embedded 25 passed, standalone 14 passed.
Acceptance criteria
apps.jsonaccepts"type": "iframe"+"url"<iframe>in the chrome at/knowledge-base/{slug}/"temporary": trueflag (warned at build time) marks entries for migrationHEADLESS_RULES.mdnotes the iframe option + its temporary natureCloses #10
🤖 Generated with Claude Code