Add Knowledge Loop agent#18
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: edf29e8dea
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Svaag
force-pushed
the
feature/knowledge-loop-agent
branch
from
edf29e8 to
e4e5572
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e4e5572099
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Svaag
force-pushed
the
feature/knowledge-loop-agent
branch
from
e4e5572 to
e02684d
Compare
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e02684d717
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Svaag
force-pushed
the
feature/knowledge-loop-agent
branch
from
e02684d to
edf1078
Compare
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: edf1078731
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Svaag
force-pushed
the
feature/knowledge-loop-agent
branch
from
edf1078 to
3c70367
Compare
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3c70367201
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Svaag
force-pushed
the
feature/knowledge-loop-agent
branch
from
3c70367 to
eb89f7c
Compare
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: eb89f7cb43
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Svaag
force-pushed
the
feature/knowledge-loop-agent
branch
from
eb89f7c to
82a014f
Compare
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 82a014fe08
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| runner: CommandRunner, | ||
| report: KnowledgeLoopReport, | ||
| ) -> None: | ||
| _run_checked(_knowledge_cmd(config, "ingest"), repo, runner, report) |
There was a problem hiding this comment.
When the loop runs in the intended systemd/local context with no GITHUB_RUN_ID, this unconditional ingest call rewrites generated concepts and exports with fresh utc_now()/run_id() metadata (last_verified_at, manifest run_id, claim timestamps) even if the source snapshots are unchanged. _git_dirty() will then see a dirty worktree and --create-pr can open a PR containing only refresh timestamps, so the new idle path is effectively unreachable for real ingest runs despite the loop being documented/tested as deterministic when no knowledge changed.
Useful? React with 👍 / 👎.
| report.ledger = ledger | ||
| return report | ||
|
|
||
| learning_event_count = _learning_event_count(config.learning_event_paths) |
There was a problem hiding this comment.
With --repo-path set and a relative --learning-event path, the budget preflight counts events in the supervisor's current directory here, but the actual ledger import subprocess later interprets the same relative path with cwd=repo. In deployments that invoke the loop from outside the checkout, valid repo-relative inputs can fail before import or be counted from a different location than the files that are imported, which makes the daily learning-event budget and phase-2 import behavior inconsistent.
Useful? React with 👍 / 👎.
1 participant
Summary
docs/plans/hyrule-knowledge loop --onceas a governed producer agent skeletonValidation
uv run ruff check src testsuv run mypy --strict srcuv run pytestuv run hyrule-knowledge validate okfuv run hyrule-knowledge quality --checkuv run hyrule-knowledge export --checkuv run hyrule-knowledge eval --checkuv run hyrule-knowledge ledger --checkuv run hyrule-knowledge ledger lifecycle --checkuv run hyrule-knowledge scan-secrets okf exports reports evals ledger schema